From aa706d714294b83db696de2beca9a722a512796f Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Tue, 19 Apr 2022 14:04:40 -0700 Subject: [PATCH] cmake: Disable nonnull-compare warning on gcc GCC finds a legit warning which clang does not on code like this class Message; void SendResponse(Message & aMessage) { if ((&aMessage) != nullptr) { return; } } Perhaps it should be fixed upstream but for now disable treating this warning as error when using gcc Upstream-Status: Pending Signed-off-by: Khem Raj --- CMakeLists.txt | 4 ++++ 1 file changed, 4 insertions(+) --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -59,6 +59,10 @@ endif() set(CMAKE_CXX_EXTENSIONS OFF) set(CMAKE_EXE_LINKER_FLAGS "-rdynamic ${CMAKE_EXE_LINKER_FLAGS}") +if (CMAKE_CXX_COMPILER_ID MATCHES "GNU") + add_compile_options(-Wno-error=nonnull-compare) +endif() + if (OTBR_COVERAGE AND CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang") message(STATUS "Coverage: ON") target_compile_options(otbr-config INTERFACE -g -O0 --coverage)